ci: manual canary ci job #1118
ci: manual canary ci job #1118
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
/canary-ci run |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
/canary-ci run |
|
/canary-ci run |
1 similar comment
|
/canary-ci run |
|
/canary-ci run |
|
/canary-ci run |
1 similar comment
|
/canary-ci run |
|
/canary-ci run |
tylersayshi
force-pushed
the
canary-ci-again
branch
from
154f89d to
7ecc301
Compare
.github/workflows/canary-ci.yml
Outdated
| outputs: | ||
| react_version: ${{ steps.get-version.outputs.react_version }} |
There was a problem hiding this comment.
my understanding is that this is how github is able to know to store this value so it's available in the other jobs to be referenced as react_version: ${{ needs.parse-version.outputs.react_version }}
There was a problem hiding this comment.
https://github.com/pmndrs/jotai/blob/93f2e16a4b4976eaf060273ea293d07c9d6e6d61/.github/workflows/ecosystem-ci.yml is my work. I didn't use outputs: and it seems working. Can you try removing it?
Or, if it's truly required, I need to fix mine.
Yeah, I think so! |
|
with this failing with rc.1 - I think there is an issue with how react is being updated and installed |
.github/workflows/canary-ci-wip.yml
Outdated
| pull_request: | ||
| types: [synchronize] | ||
|
|
||
| jobs: | ||
| canary-ci: | ||
| uses: tylersayshi/waku/.github/workflows/e2e.yml@canary-ci-again |
There was a problem hiding this comment.
By the way, this is a very nice way. I hadn't thought about it.
|
e2e test failing with the latest canary seems like a real issue for us (related with react-compiler). We should fix it but not in this PR. canary-ci will help confirming the fix. |
#1118 seems to have some issues for comment triggers.
While working on #1118, I noticed an e2e test fails with the latest canary. It seems to related with react-compiler.
🐤
Cleanup todo:
@mainfor uses field for reusable workflow file